PHI-base / PHI5_web_display

PHI5_web_display will allow to display PHI-Canto data
1 stars 0 forks source link

'Effector' high level term not displayed on effector gene pages #63

Closed jseager7 closed 1 year ago

jseager7 commented 1 year ago

The gene pages for effector genes are not showing the 'Effector' high level term.

In the instructions for mapping the PHI-base 4 high level terms to data in PHI-base 5, we decided that the 'Effector' high level term should be displayed in the following cases:

Using PHIG:277 as an example, this means that the 'Effector' high level term should be displayed in all of the following places.

In the Entry Summary:

image

In the Additional information section for every phenotype annotation that includes the gene, meaning Gene for Gene Phenotype and PHI Phenotype:

image

And in the GO Biological Process section for any annotation with the term GO:0140418 or any of its child terms.

image

jseager7 commented 1 year ago

@CuzickA In issue https://github.com/PHI-base/PHI5_web_display/issues/17 we decided we wanted to show the 'Effector' high level term on PHI phenotypes and GfG phenotypes in addition to the GO Biological Process annotations.

But, do we only want to display the 'Effector' term on the gene page for the effector gene, or should it also be shown on the host gene pages for the metagenotypes where the host gene is involved in an interaction with an effector?

Doing so would mean that the 'Effector' high level term would be automatically displayed in the Entry Summary section for the host gene, which could create the misleading impression that the host gene is an effector.

jashobanta-mcpl commented 1 year ago

It's fixed . Ref : PHIG:277 image

jseager7 commented 1 year ago

@jashobanta-mcpl Thanks, but please could you capitalise "effector" to "Effector", since that's how it appears in other High level term sections:

image

We also need the Effector high level term shown in the "PHI high level term" column of the Entry Summary section, which is what happens with other high level terms.

image

It's currently not shown on the gene page for PHIG:277.

jseager7 commented 1 year ago

Confirmed as fixed based on a random sample of effector genes (A9JX75, G4MXR2, Q00363).