PHI-base / PHI5_web_display

PHI5_web_display will allow to display PHI-Canto data
1 stars 0 forks source link

Include strain name in genotype / metagenotype pop-up #79

Closed jseager7 closed 1 year ago

jseager7 commented 1 year ago

Currently, the pop-up on the genotype or metagenotype display name does not show the strain name for the pathogen or host. This seems like an oversight, as the strain name is shown in the genotype or metagenotype display name, and the pop-up already displays the species name (but see #78).

We want the strain name included in the pop-up for both genotype annotation types and metagenotype annotation types. For metagenotypes, that includes the PHI Phenotype, Gene for Gene Phenotype, and Disease Name annotation types.

Here's an example of what the pop-up should look like for a PHI Phenotype for PHIG:253.

image

We'd also want the strain name displayed for other annotation types on a single species, like Pathogen Phenotype and Host Phenotype:

image

jseager7 commented 1 year ago

Confirmed that this is fixed for Pathogen phenotype, Host phenotype, PHI phenotype, Disease name, and Gene for Gene phenotype.

jseager7 commented 1 year ago

@jashobanta-mcpl I'm reopening this issue since I've found cases where host genotypes in the Host phenotype section do not have species names or strain names in the pop-up.

For example, on the gene page for PHIG:276:

image

Here's what I expected to see:

image

Here's all the host gene pages I found with this problem: PHIG:276, PHIG:279, PHIG:280, PHIG:281, PHIG:283, PHIG:284, PHIG:285, PHIG:359, and PHIG:361.

jseager7 commented 1 year ago

Confirmed that the strain names are now shown for pathogen phenotypes:

image

...and host phenotypes:

image