PHI-base / canto-docs

User documentation for the PHI-Canto project
MIT License
0 stars 0 forks source link

Add documentation for disease annotations #13

Closed jseager7 closed 3 years ago

jseager7 commented 3 years ago

This pull request will add a new page for the 'Disease name' annotation type. I've taken the decision not to include the disease annotation type in the 'Curating phenotypes' page because it's not a phenotype annotation.

Follow the link below to see the latest draft of the documentation page for disease annotations:

https://github.com/PHI-base/canto-docs/blob/disease_annotation/docs/disease_annotation.md

@CuzickA I have a few questions about the text I've written:

jseager7 commented 3 years ago

We resolved the temporal problem by deciding that we should stick with PomBase's convention that multiple extensions of the same type have the meaning of occurring simultaneously instead of independently.

jseager7 commented 3 years ago

@CuzickA In order to add images for the Disease annotation help page, I need an example of a metagenotype I can use for the disease annotation. I also need a term from PHIDO that I should use, and a tissue type. We can probably just pick one disease annotation from an existing session.

CuzickA commented 3 years ago

How about this one https://canto.phi-base.org/curs/d7b3170ded99924f/ro/

image

jseager7 commented 3 years ago

That's great, thanks.

jseager7 commented 3 years ago

@CuzickA I think the disease annotation page is ready to be reviewed, when you have time. Here's a link to the latest draft:

https://github.com/PHI-base/canto-docs/blob/disease_annotation/docs/disease_annotation.md

Please let me know if it looks okay. If there are no changes required then I'll merge this into the repository and enable it on PHI-Canto.