Closed JonMWilkes closed 1 year ago
Thanks for creating this ticket @JonMWilkes
Curation link: https://canto.phi-base.org/curs/9912dcabc045a08e/ro/
Checking Curation of Fig 1
Current
I have updated to
Maybe this could also have AE 'assayed with' IL8 etc
Looks like these annotations are for Fig 2
I think these 'cell invasion assays' are the same as a penetration assay. Maybe 'cell invasion' could be added as a synonym to the PHIPO penetration terms.
I have deleted the 'conditions' that were entered as this information has already been captured with the evidence. Conditions are generally increased temp or adding a chemical.
@JonMWilkes and @ValWood, please let me know what you think about my edits.
@jseager7 It looks like the PHIPO term 'infective ability phenotype' can be selected for annotation (see top screenshot above). This term is in do not annotate subsets. Please could you look into this. Thanks.
@CuzickA It isn't normally possible to annotate this term. Canto's default behaviour is to still show terms in the qc_do_not_annotate
subset in the autocomplete, but not allow them to be annotated once selected. Here's what you see when you try to actually select the term:
As shown in the image, there's no option to continue.
The only way to bypass this check is to enter the term ID instead of the term label into the text input, in which case Canto skips the check. I don't think this is a bug, but an intended workaround for expert curators in the (rare) case that the qc_do_not_annotate
warning is wrong and should be ignored. This doesn't seem like one of those cases: usually the term suggestion feature should be used when there's no appropriate term.
If you want Canto to be stricter about this, I can add qc_do_not_annotate
to the list of subsets that are ignored in the primary autocomplete, meaning they won't even appear to the user.
This might not be ideal though, since curators might start suggesting terms that exist in the ontology but are marked as do not annotate, because they'll have no way of ever seeing the terms and realising that it's redundant to make a term suggestion.
Also, even hiding terms from the autocomplete won't stop curators who enter term IDs. If we want to prevent that, then it will require new code changes and new configuration in Canto.
Thanks for clarifying the above @jseager7.
@JonMWilkes please could you let us know 'how' you entered the term above 'infective ability phenotype'? Did you enter a term id or select the text from the dropdown menu?
Jon, the reason I'm asking about this is that 'infective ability phenotype' is a grouping term for the infective ability AE terms e.g. 'reduced virulence' but should not be available as a primary PHIPO annotation term. Please let me know if you have any questions.
Checking Figure 3
Original annotations
Updated annotations
Hi @JonMWilkes, these types of annotations follow a two-step approach 1) primary PHIPO annotation e.g. 'survival of host organism with pathogen' 2) adding the AE 'infective ability' to record 'unaffected pathogenicity', 'reduced virulence' etc.
It should not be possible to select these 'infective ability' terms as primary PHIPO annotations (discussion above).
Please let me know if this two-step process makes sense to you and whether you think our help documentation needs to make this clearer?
@CuzickA - I have not used any term id in the annotation process and all selections have been made from drop downs menus. Hope this helps.
@CuzickA - I have not used any term id in the annotation process and all selections have been made from drop downs menus. Hope this helps.
Thanks for this info @JonMWilkes
Are you able to provide a screenshot here in this ticket, where you are able to select e.g. 'reduced virulence' as a primary PHIPO annotation from a dropdown menu please
Figure 4
Original annotations
Updated annotations
We may need to make 2 lots of annotations here, one for amount of pathogen growth in host and one for tissue to tissue migration.
I will need to make a new PHI-ECO term for '11 hpi' and a new PHIPO term for 'decreased pathogen tissue to tissue migration within host'
Table 2
Original annotations
Updated annotations
Hi @ValWood, I'm really not sure about this one! How should we annotated an altered weight of a host organ? Do you think it falls under 'host morphology phenotype during pathogen invasion' or 'abnormal host structure induced by pathogen'?
Hi @CuzickA,
Here is a dummy annotation I did where I selected a reduced virulence phentotype - you should be able to reproduce the selection from the history at the top (boxed)
Figure 5
Original annotations
Updated to
@ValWood, what do you think of this way of annotating lung tissue inflammation?
The WT should probably be ''inflammatory response present''.
Hi @CuzickA, Here is a dummy annotation I did where I selected a reduced virulence phentotype
Hi @JonMWilkes, thanks for your screenshot above. I was able to reproduce your method and was also able to select 'reduced virulence' phenotype.
@jseager7 it looks as if you cannot search for 'reduced virulence' directly, but if you search for parent term 'virulence phenotype' the child terms are available for selection. The same happens for 'pathogenicity phenotype', mutualism phenotype and the overall grouping term 'infective ability phenotype'. By drilling down the terms it is possible to select the children for annotation.
Hope that helps with fixing the problem :-)
S Fig1
Original annotation
updated annotations
@ValWood, do you think this term 'death of host organism with pathogen' is suitable for cell cytotoxicity assays (pathogen being added to host cells)? Do we need a term at the 'cell' level or perhaps we could broaden the definition to include 'cell' as part of the individual organism?
Regarding the strain for the desB mutant
It may be best to use 'PAO1' as this is what the desB mutant is being compared to and will be more informative to the PHI-base data users.
I will delete the desB mutant entry highlighted in Green. We are aiming to just curate the 'disease' for the Wild type metagenotypes.
I've finished checking through this session now.
@JonMWilkes this has been a good curation session and a really useful exercise. Several issues have been identified, including the PHIPO infective term display, the 'two-step curation method', requirement for new PHIPO and PHI-ECO terms, and a few questions that I have for Val about the best way to curate some expt types.
@ValWood, what do you think of this way of annotating lung tissue inflammation?
it isn't really a morphology phenotype. I would be inclined to have a generic term "decreased inflammatory response". That would probably be enough, especially since you know the lung tissue is infected. I don't think you want a term for every tissue type.
For the "death of host organism" question. Don't you have a term for host cell death that you could use?
I'm really not sure about this one! How should we annotated an altered weight of a host organ? Do you think it falls under 'host morphology phenotype during pathogen invasion' or 'abnormal host structure induced by pathogen'?
What is the intent of the experiment? Is it just to show increased pathogen load? Or something else?
It looks as if you cannot search for 'reduced virulence' directly, but if you search for parent term 'virulence phenotype' the child terms are available for selection. The same happens for 'pathogenicity phenotype', mutualism phenotype and the overall grouping term 'infective ability phenotype'. By drilling down the terms it is possible to select the children for annotation.
@CuzickA What I'm more confused about is why, in my test session, it's not possible to see terms in the qc_extension_only
subset, but it is possible to see terms marked as qc_do_not_annotate
.
Our configuration for these subsets is almost identical – in that qc_extension_only
and qc_do_not_annotate
are both meant to be ignored in the primary_autocomplete
and primary_select
configuration – the only difference is that qc_do_not_annotate
is in the do_not_annotate_subsets
configuration, while qc_extension_only
isn't.
Since the current behaviour of qc_extension_only
seems to be hiding the terms from the term selector entirely (and not just blocking them from being selected), it seems like a bug that the qc_do_not_annotate
terms are being shown at all. I'm no longer sure what Canto's intended behaviour is, so I'll have to open an issue on the Canto repository.
Hi @CuzickA, Here is a dummy annotation I did where I selected a reduced virulence phentotype
Hi @JonMWilkes, thanks for your screenshot above. I was able to reproduce your method and was also able to select 'reduced virulence' phenotype.
@jseager7 it looks as if you cannot search for 'reduced virulence' directly, but if you search for parent term 'virulence phenotype' the child terms are available for selection. The same happens for 'pathogenicity phenotype', mutualism phenotype and the overall grouping term 'infective ability phenotype'. By drilling down the terms it is possible to select the children for annotation.
Hope that helps with fixing the problem :-)
This has now been fixed. When I search for 'virulence phenotype', 'pathogenicity phenotype', 'mutualism phenotype' these terms are no longer available in the dropdown.
I will hide above comments relevant to this now it has been resolved.
It may be best to use 'PAO1' as this is what the desB mutant is being compared to and will be more informative to the PHI-base data users.
I have update the mutant strain to PAO1 and deleted the bespoke strain 13272
Fig S1 above
@ValWood, do you think this term 'death of host organism with pathogen' is suitable for cell cytotoxicity assays (pathogen being added to host cells)? Do we need a term at the 'cell' level or perhaps we could broaden the definition to include 'cell' as part of the individual organism?
For the "death of host organism" question. Don't you have a term for host cell death that you could use?
@ValWood How about 'presence of pathogen-associated host lesions' ? Would this fit for cell cytoxicity?
def:
Table 2
I'm really not sure about this one! How should we annotated an altered weight of a host organ? Do you think it falls under 'host morphology phenotype during pathogen invasion' or 'abnormal host structure induced by pathogen'?
What is the intent of the experiment? Is it just to show increased pathogen load? Or something else?
Build up of liquid/ swelling in host is greater with WT pathogen than with mutant.
@ValWood Could this be curated with inflammation terms? maybe... WT metagenotype 'inflammatory response present' desB mutant metagenotype 'decreased inflammatory response'
Figure 2
I think these 'cell invasion assays' are the same as a penetration assay. Maybe 'cell invasion' could be added as a synonym to the PHIPO penetration terms.
PHIPO looks like this
@JonMWilkes and @ValWood do you think it would be worth adding 'invasion' as a synonym to these terms. I remember from discussion with Jon that 'penetration' may not have been clear enough on its own.
I think you could add as related, or broad (Invasion seems to cover more than just penetration- it could even be the life cycle stage.
Hi @ValWood, I'm confused by which term I should use for cell cytotoxicity expt in FigS1.
WT and mutant Bacteria is added to human cell line to look for host cell death. A host cell viability assay with pathogen.
As far as I can see, we have the following PHI terms
at the organism level
term for pathogen-associated host lesions present
There are no relevant cell death terms under the PHI Cell phenotypes
Which do you think is most suitable in this case?
Need to add AE 'protein_assayed' to 'host defense-induced protein present' PHIPO:0001251 please @jseager7
I thought you had some host cell death terms?
In the single species branch there is 'host cell death' but this is without a pathogen
and single specie 'cell viability'
Need to add AE 'protein_assayed' to 'host defense-induced protein present' PHIPO:0001251 please @jseager7
@CuzickA I've done this now, though it probably won't be visible until PHI-Canto is restarted.
I guess you could introduce a host cell viability with pathogen phenotype. I worry about the proliferation of phenotypes, but maybe you will need these are you annotate more human cell-based papers.
I was wondering why the single-species branch need to mention "host"? Why not just "cell death" if this isn't part of a pathogen-host interaction?
Maybe you do not want to curate every piece of supplementary information. What is the author intent? If the author intent is to show that the immune system is affected perhaps these are the terms you would use ?
I will also need to curate similar expt for Fig 2 in https://github.com/PHI-base/curation/issues/102
Yes, its this difficulty with cell, tissue, organism level that we've had in the past.
Do you think new 'host cell viability with pathogen phenotype' would fit under the organism level terms or PHI cell phenotypes?
I was wondering why the single-species branch need to mention "host"? Why not just "cell death" if this isn't part of a pathogen-host interaction?
I think we did this to indicate when a mutation in a pathogen results in a lethal/ inviable phenotype and in the host case, where a mutation activates the HR defense response causing cell death (without a pathogen being present). Do you think these need to merged?
I thought that you were keeping pathogen/host out of the single-species branch, because that could be inferred from the context?
Looking at some past tickets
Might help with single species 'cell viability' https://github.com/PHI-base/phipo/issues/298
Might help for the 'cell death terms' https://github.com/PHI-base/phipo/issues/306
I thought that you were keeping pathogen/host out of the single-species branch, because that could be inferred from the context?
Moving this single species discussion over to https://github.com/PHI-base/phipo/issues/298
Added new terms, annotation for Fig S1 now looks like this
This session has now been approved and I am closing the ticket.
@CuzickA There's an unused gene in this session: CXCL8 of Homo sapiens (UniProtKB:P10145) has been added but isn't annotated nor used in any assayed_using extensions.
I'm guessing CXCL8 was meant to be used in an assayed_using extension, since that's how the other human gene (IL6) has been used.
Note that unused genes will still be given their own gene page (and PHIG ID) in PHI-base 5 as it stands, so we should try to avoid this.
@jseager7 Good spot. I will go into the session and recheck / delete it. Do we have any type of automated checking mechanism to prevent this happening again? I suppose its up to the person checking the curations but could be easy to miss.
There's no automated checking for this in PHI-Canto itself. We could add checks to the PHI-base 5 website to exclude genes with no annotations or usage in extensions, but the safest option is probably to add automated checks to the PHI-Canto JSON export to remove any gene objects that are unused.
I have just added the missing Fig1 assayed_using IL-8 annotations and reapproved session.
Automated checks would be useful.
Automated checks would be useful.
I've added that to my to-do list.
Initial curation completed and submitted to Phi-canto