Closed ValWood closed 6 years ago
link to FYPO peco https://github.com/pombase/fypo/blob/master/peco.obo Also consider plant expt conditions ontology http://purl.bioontology.org/ontology/PECO
URLS to open in protege https://raw.githubusercontent.com/pombase/fypo/master/peco.obo (not registered with OBOfoundry) http://purl.obolibrary.org/obo/peco.owl
A few queries after a quick look through of FYPOpeco
Thoughts after a quick look through of PECO
Some thoughts, should discuss on next call.
You don't need logical definitions here. There isn't a lot of maintenance required (our PECO is largely a flat list).
We discussed this briefly on our call today , whether to rename but decided not to in the short term. We intend in the longer term to maybe migrate these into an existing condition ontology.
Because of the nature of your annotation (annotating both pathogens and host), I suspect you may always need multiple condition ontologies, or different ontologies in different aspect. Maybe change PHI-Canto to use multiple condition ontologies (or ontology subsets) simultaneousty.
We have no browsing capability for condition selection in Canto (it's just a look up)
You might want to just plug in the existing ontologies rather than maintaining another ontology. You could request terms not covered in ours or the plant one.
We could also tell the plant-PECO that we intend to use the ontology and ask if they could consider adding subsets or taxon restrictions.
Could you give an example here. Do you mean in the phenotype ontology?
This may be a bit hard to explain... When making a phenotype annotation (and also GO annotations etc) will the curator run through the whole curation process in a species-neutral manner without specifying the 'type' of pathogen (and host) organism eg bacterial/fungal other than in the NCBI taxon ID species name or uniprot species name information. Will all of our phenotype terms/ expt evidence and condition terms be species neutral?
Hopefully.
Do you have a specific example?
If the phenotype is applicable to all species it is best. If you have phenotypes which are not applicable to all species, we can add taxon restrictions. This means, for example if you would annotate to
stem cancer not wheat stem cancer
Some terms may apply to both pathogens and hosts (abnormal membrane morphology). Probably these will just need ancestry to both host phenotype and pathogen phenotype.
Is this what you mean?
In the Plant experimental conditions ontology some of the condition terms have 'plant' in the text
eg term: biotic plant exposure def: 'A plant exposure involving the application of a biotic or biological factor such as a microbe, insect, animal, or plant or a combination thereof'
If we wanted to use this conditions term we may modify it to 'biotic host exposure'. This may be a condition assigned to the expt evidence 'functional test in host'.
It just got me thinking that we will probably want to make each curation step species neutral the phenotypes, the evidence and the conditions.
so in this case why can't you use "biotic plant exposure"? would it be ambiguous in some cases?
Although I'm not sure why they include 'plant' if all of the terms in this ontology are plant conditions, it's probably because this is how a human would expect to see it written). I would have expected "exposure to biotic". Maybe they include plant in terms which could apply to non-plants.... You probably don't need to worry too much about this, if it works/is unambiguous in the context that you are using it, it will be fine.
this condition wouldn't be species neutral....the host may be an animal instead of a plant.
Yes it does seem odd that they include 'plant' so frequently within the plant conditions ontology.
ah ok, I see....we might need a mechanism to select the appropriate condition ontologies behind the scenes depending on the pathogen and host species selected.
Let's begin using PECO-plant. It's not a show stopper if the appropriate terms are not present for other host types because any condition can be typed for fixing up later. This way we will see what people actually require.
Current decisions
Progress
Removed above file from google drive, updated it and added to PHI-base/config repo
I had a note to say, I always find this useful to refer to:
I'm closing this issue for now as have a draft version at above link.
@CuzickA
The "conditions ontology" used with individual phenotype ontologies is configurable as soon as this is available (even a mini-version) use at import to test