PHI-base / phipo

Pathogen-Host Interaction Phenotype Ontology
Other
5 stars 5 forks source link

Replace 'expedited' with 'premature' in term labels #284

Closed jseager7 closed 3 years ago

jseager7 commented 3 years ago

I've noticed that a few PHIPO terms use 'expedited' or 'expedited timing' in their term names. For example: 'expedited timing of penetration structure formation' (PHIPO:0000109), which has the following definition:

A single species pathogen growth phenotype in which formation of pathogen specialized penetration structure begins sooner than normal when assessed for penetration ability on a given experimental substance/membrane.

This seems semantically identical to the PATO definition of 'premature' (PATO:0000694):

A quality of a process which starts earlier than the natural start time or the reference process.

It might help to reduce confusion if we align our terminology to an established ontology. 'Premature' is also less verbose than 'expedited timing'.

Note that the formal semantics are provided by the phenotype pattern for this term (abnormally premature biological process), so the changes I'm proposing are strictly to make the terms easier to understand for curators.

ValWood commented 3 years ago

Yes agreed!

@jseager please alert if you see any more obvious verbose term names that can be standardized. This is really useful.

I am also going to have a look at terms and definitions in a couple of weeks, and then @mah11 will have a look over, so between us we should be able to identify most of the language inconsistencies.

jseager7 commented 3 years ago

I've made this change. All references to 'expedited' and 'expedited timing of' have been replaced with 'premature'. Closing now.

jseager7 commented 3 years ago

And I've just noticed the commit message is wrong. I'll recommit the change, and try to remember to read next time... 😩