PHI-base / phipo

Pathogen-Host Interaction Phenotype Ontology
Other
5 stars 5 forks source link

organism growth phenotypes #41

Closed CuzickA closed 5 years ago

CuzickA commented 5 years ago

Under the single 'organism phenotype namespace' I have begun to merge pathogen and host only growth phenotypes. This is what we currently have image

Queries 1) what else fits in here? 2) although aiming for species neutral phenotypes we will also need some species specific phenotypes such as filamentous growth -does this seem ok? 3) should reproductive phenotypes be added here or kept separate?

mah11 commented 5 years ago

what else fits in here?

Sorry, I don't know this biology well enough to help with this question.

although aiming for species neutral phenotypes we will also need some species specific phenotypes such as filamentous growth -does this seem ok?

Yes, as long as a species-neutral phenotype is never a subclass or part of a species-specific phenotype.

should reproductive phenotypes be added here or kept separate?

I'm inclined to keep them separate (as they are in GO).

ValWood commented 5 years ago

Any abnormal biological process, morphology or function not related to pathogenicity will probably go under here.

You will also probably have a lot of plant structure related terms (these not covered by GO). I presume there PO can be used to define these , but maybe leave those for a little while and concentrate on the most used terms and especially the pathogen-host interactions.

it is important to disambiguate these

CuzickA commented 5 years ago

I agree I think it would be better to change the namespace to 'single species' phenotypes. @jseager7 is looking into how this would affect PHI-Canto ontology loading and the changes that will need to be made.

It is possible that the chemistry phenotypes will also fall under growth phenotypes.

Regarding the stature phenotype - I'm not sure if this would be plant specific. Perhaps a host mutation in a mouse would alter its height but I'm not sure if this phenotype would be captured more as 'small'? Something to think about when we trial these types of papers for curation. I also wondered about the 'stature' overlap when describing 'decreased aerial height of filamentous growth' image should this be a child of 'stature' or 'filamentous growth'?

CuzickA commented 5 years ago

Regarding the 'yeast-like growth form phenotype'. I was curating PMID: 29020037 Zymoseptoria tritici is a dimorphic fungus and is able to growth in both a 'yeast-like' and 'filamentous' form depending on conditions. The ZtGT2 mutant (grown under various conditions) resulted in normal yeast like growth but abnormal filamentous growth (short filaments, sinusoidal (wavy) filaments) -would this be classed as morphology? image

ValWood commented 5 years ago

agree I think it would be better to change the namespace to 'single species' phenotypes.

ValWood commented 5 years ago

Regarding the 'yeast-like growth form phenotype'. I was curating PMID: 29020037 Zymoseptoria tritici is a dimorphic fungus and is able to growth in both a 'yeast-like' and 'filamentous' form depending on conditions. The ZtGT2 mutant (grown under various conditions) resulted in normal yeast like growth but abnormal filamentous growth (short filaments, sinusoidal (wavy) filaments) -would this be classed as morphology?

Yes this one is morphology. Yikes this is complicated! really it now required a life-cycle stage ontology too- but we will fudge that into PHIPO for now!

we need some way of saying normal yeast-stage morphology
abnormal morphology during filamentous growth

(here the word 'growth' is being used to describe a 'life cycle phase i.e period of growth' rather than a "size increase'...size does increase- but it isn't directly related to the observation, size and shape are independent of each other- you are lucky we have thought about this a lot, although Midori could likely explain it Much better)

CuzickA commented 5 years ago

just to note we plan to add chemistry phenotypes #43 and spore germination phenotypes #44 under growth phenotypes

CuzickA commented 5 years ago

I expect the 'penetration phenotypes' #32 (in both single species and pathogen host interaction namespaces) will also fall under growth phenotypes.

In the pathogen host interaction namespace would they also need to link to virulence and pathogenicity phenotypes or is this orthogonal information? One annotation could curate whether the pathogen penetration of the host was normal/abnormal and then a second annotation could indicate how this affected pathogenicity or virulence.

ValWood commented 5 years ago

https://www.ebi.ac.uk/QuickGO/term/GO:0036267 might be useful for the logical def

Val

CuzickA commented 5 years ago

Trying to figure out which parents 'organism growth phenotypes' would have #42

Also @jseager7 where did we get to with changing the namespace name - is there a ticket for this?

I agree I think it would be better to change the namespace to 'single species' phenotypes. @jseager7 is looking into how this would affect PHI-Canto ontology loading and the changes that will need to be made.

jseager7 commented 5 years ago

where did we get to with changing the namespace name - is there a ticket for this?

@CuzickA There isn't any ticket open for this, and there hasn't been any progress with it, since we still haven't fixed the bugs that occurred in Canto from the last namespace merge. Given recent discussion about the possibility of moving all the terms into one default namespace (and handling term groupings with subsets instead), we might want to wait until we've reached a decision on that before changing the existing namespace again.

CuzickA commented 5 years ago

Closing this older ticket