search

PHLAK / Config

PHP library for simple configuration management
https://packagist.org/packages/phlak/config
MIT License
50 stars 11 forks source link

Updated for php 8.1 & removed deprecated warnings #25

Closed Externaluse closed 1 year ago

Externaluse commented 1 year ago

Hi, I love Config but ran into a few problems with PHP >=8.1, e.g. deprecated warnings. I've updated an abandoned library as well, and updated the others to where support <8.1 wasn't required, and migrated the phpunit xml. 50 tests and 88 assertions ran ok.

Externaluse commented 1 year ago

That all looked fine, thanks! Would be great if you could consider this for a release or version bump

Externaluse commented 1 year ago

Is there any more that I can do at the moment? My debugger is still shouting the deprecated warnings at me on every request... Deprecated: Return type of PHLAK\Config\Config::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in... times 5... A version bump for composer would be absolutely fab!

PHLAK commented 1 year ago

I'll get this merged but there's some additional work I want to do before making a release.

If the deprecation warnings are the only issue you can safely ignore those for now and/or update the error_reporting configuration option in your php.ini file or at runtime. The setting below will show all errors except for deprecation and strict warnings. This is the recommended settings for production.

error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT