PHOTOX / promdens

Initial condition filtering with laser pulse.
0 stars 0 forks source link

Move plotting into functions #12

Closed danielhollas closed 1 week ago

danielhollas commented 2 weeks ago

Moving plotting into separate functions, towards #2.

Might be hard to review in on Github, probably better to open locally. But I just literally moved the code into functions and adjusted some print statements.

JanosJiri commented 1 week ago

Cool, no problem with moving plotting into separate functions. However, I made some modifications which I implemented in the latest commit.

If you are happy with it @danielhollas , feel free to squash and merge. Thanks for all the awesome work!

danielhollas commented 1 week ago

Thank you for the review and fixes / tweaks!

I had Figure names as 'Figure 1' etc. to match with the window title so that people could easily see what window was open. I solved it now by renaming the window. It looks like this and you can directly locate the right window mentioned in the output.

Good point, thanks for figuring out how to set the window titles.

I think it's useful because it will make people think twice if they input the right units. If we don't convert any units, the code won't print anything. It's just a tiny change so I added it here. I didn't touch any functionality of the code, just printing.

Very good point. However, I think that it is also important (perhaps even more) to print something when there is no conversion, since that is actually more likely to mean that the user forgot to specify the units since a.u. is the default. We can address that in another PR.