search

PHOTOX / promdens

Initial condition filtering with laser pulse.
0 stars 0 forks source link

Move code to `main()` #13

Closed danielhollas closed 1 week ago

danielhollas commented 1 week ago

This is a last PR that mostly just moves code. Now that all the code is out of global scope, we can make this into an importable module / package in next PR.

This also exposed a couple of cases in sample_initial_conditions() method which relied on global variables.

Closes #2

danielhollas commented 1 week ago

@JanosJiri thanks for the review. Agree that formatting is a matter of taste and should be dealt separately. Ideally in the future we'd have autoformatter running automatically in CI so that the formatting doesn't depend on personal configurations.

Personally I find that a lot of the lines in the current code are quite long. But again that's a matter of preference.

For now could you please autoformat the file according to your config and push to this branch. Feel free to fix the typos as well.

JanosJiri commented 1 week ago

@danielhollas I see your point. Maybe it would be best to later find a way in between with the formatting. We can later set up a format to solve it. Thanks again for the work. I have changed the typos and I'm going to squash and merge the pull request.