search

PHP-DI / Silex-Bridge

PHP-DI integration in Silex
http://php-di.org/doc/frameworks/silex.html
MIT License
24 stars 8 forks source link

Compatibility with Silex 2 #17

Closed jdreesen closed 8 years ago

jdreesen commented 8 years ago

Due to the latest changes in this bridge it was a bit tricky to make it compatible with Silex 2 but the tests all pass now.

mnapoli commented 8 years ago

That's great! I've given you write access to the repo so feel free to merge master back into the working branch, that way the PR will be cleaner

jdreesen commented 8 years ago

Oh wow, thx :blush: Will do soon!

felixfbecker commented 8 years ago

Thanks alot @jdreesen for taking the work to adapt this all to Silex 2! Regarding your implementation of HttpKernelServiceProvider, I don't hink a cleaner implementation is possible. It actually is better than what we did before (overriding the whole subscription process). The loop shouldn't be too bad actually as it is asking for the specific event names of the subscriber.

jdreesen commented 8 years ago

I merged master into the silex-2 working branch and split the cleanup commit into another PR (which I'll open when this one is merged) to reduce the noise. I've been a little busy the last days, sorry for the delay.

jdreesen commented 8 years ago

I'll write unit tests for the new HttpKernelServiceProvider if I find some time, hopefully tomorrow.

mnapoli commented 8 years ago

That's awesome! I haven't had too much time too I'll review asap

FYI I am planning to release PHP-DI 5.3. It doesn't contain a new major feature so I was planning on releasing the Symfony bridge 2.0 at that time. I think I'll also wait for this new version of this bridge to advertise all those changes.

Brammm commented 8 years ago

Hey guys, nothing to contribute at the moment, just wanted to let you know, awesome stuff. We're actively using this.

jdreesen commented 8 years ago

Actually, I'm not sure how to properly unit test this stuff. Besides that there are already functional tests for this behaviour.

mnapoli commented 8 years ago

Sorry @jdreesen I was waiting for an answer on one of the comments and didn't see you did. Anyway if it's all good here I'll merge.

I'll tag a 2.0.0-beta1! After a few weeks we'll tag a stable release and I'll write a blog post for this.

mnapoli commented 8 years ago

Thanks @jdreesen, I've tagged 2.0.0-beta1 -> https://github.com/PHP-DI/Silex-Bridge/releases/tag/2.0.0-beta1