search

PHP-DI / Silex-Bridge

PHP-DI integration in Silex
http://php-di.org/doc/frameworks/silex.html
MIT License
24 stars 8 forks source link

[Silex2] Cleanup #18

Closed jdreesen closed 8 years ago

jdreesen commented 8 years ago

Since Silex 2 requires PHP >= 5.5 we can now use ::class. I also fixed some small typos and removed some unused imports.

mnapoli commented 8 years ago

https://www.youtube.com/watch?v=a8c5wmeOL9o

By the way if want to enable https://styleci.io for this repo feel free to do it

jdreesen commented 8 years ago

I'll have a look into styleci.io.

mnapoli commented 8 years ago

Yep it's just a suggestion though, I personally find it quite fun but sometimes it can be a pain (configuring all rules to match the current style, or adapting to their new rules popping up every 3 months, etc.)

jdreesen commented 8 years ago

I'll play around with it a bit and then maybe enable it eventually. But I'm not sure how I could enable it for this repo because it shows only repos that are on my own account. I enabled it for my fork of this repo for now.

mnapoli commented 8 years ago

OK just let me know if you want me to enable it