search

PHP-DI / Slim-Bridge

PHP-DI integration with the Slim framework
http://php-di.org/doc/frameworks/slim.html
MIT License
177 stars 38 forks source link

Use PHP 5.5 syntax. #12

Closed Arantor closed 8 years ago

Arantor commented 8 years ago

This should fix the only obvious issues in Slim-Bridge that prevent it working on PHP 5.5. Fixes #8

I have only given it basic testing, it seems to work for my colleagues (I don't use it myself)

mnapoli commented 8 years ago

Thank you, could you update .travis.yml so that tests runs on PHP 5.5?

Arantor commented 8 years ago

I've updated it - though I've never used Travis so I don't know if that's the correct way to do it.

mnapoli commented 8 years ago

Travis configuration is correct, tests are failing because on invalid PHP code in config.php: https://travis-ci.org/PHP-DI/Slim-Bridge/jobs/141813495#L265

Also it seems that PHPUnit's version isn't compatible with PHP 5.5: https://travis-ci.org/PHP-DI/Slim-Bridge/jobs/141813494#L156 (you might need to change PHPUnit's version)

Arantor commented 8 years ago

Ugh. The check it fails is that this all hinges on PHPUnit, which also requires 5.6, and I doubt you'd merge a patch in that would cause the build to always fail as far as Travis is concerned.

Guess this was a waste of time :disappointed: but I'll leave the pull request up in case anyone who wants PHP 5.5 support can somehow make use of it. We're not all in the happy position to be using current PHP versions, unfortunately.

mnapoli commented 8 years ago

@Arantor you can change PHPUnit's version (use PHPUnit 4.*) so that it works with PHP 5.5

mnapoli commented 8 years ago

Replaced by #14