search

PHP-DI / Slim-Bridge

PHP-DI integration with the Slim framework
http://php-di.org/doc/frameworks/slim.html
MIT License
176 stars 38 forks source link

Slim 4 #47

Closed mnapoli closed 5 years ago

mnapoli commented 5 years ago

Originally #46

resolves #22

TODO:

l0gicgate commented 5 years ago

Just a heads up @mnapoli there will be upcoming breaking changes to CallableResolverInterface in Slim 4.2

I know, there’s already a lot of BC changes but unfortunately we have to do this so MiddlewareDispatcher becomes dependant on CallableResolver instead of duplicating a bunch of logic to resolve callables.

See https://github.com/slimphp/Slim/issues/2780 for more information

mnapoli commented 5 years ago

I'm putting this on hold waiting for https://github.com/slimphp/Slim/pull/2793

@l0gicgate I'm commenting in the issue you linked to.

l0gicgate commented 5 years ago

@mnapoli I think we’re in the clear here. Just released 4.2 today and we avoided all potential BCs thankfully!

mnapoli commented 5 years ago

@l0gicgate awesome, thank you for letting me know!

xndr78 commented 5 years ago

cannot wait for slim 4 support

opengeek commented 5 years ago

Is this ready to go? Is there a way to use this via composer so I can try it out on some existing projects I would like to upgrade to Slim 4?

alturic commented 5 years ago

Any update on this? Definitely interested in testing this out on Slim 4.

mnapoli commented 5 years ago

I have updated the issue description with a TODO list of what's left to do.

I have loads of work this week, I hope to get on this next week.

fritsvt commented 5 years ago

Hi @mnapoli Thanks for the update! I've created a new PR that solves the two todo items you mentioned here.

mnapoli commented 5 years ago

Merged #49, thanks @fritsvt

I have opened a PR for the documentation as well: https://github.com/PHP-DI/PHP-DI/pull/682

I'll merge everything, tag, release and deploy the new docs.

Thanks everyone for the help!

SvenRtbg commented 5 years ago

I think, with this merged https://github.com/PHP-DI/PHP-DI/issues/680 can be closed, too.

mnapoli commented 5 years ago

@SvenRtbg yes thanks!