search

PHP-DI / Symfony-Bridge

PHP-DI integration with Symfony
http://php-di.org/doc/frameworks/symfony2.html
Other
17 stars 11 forks source link

Kernel::getPHPDIContainer() should be protected not private #17

Closed jasonbouffard closed 6 years ago

jasonbouffard commented 6 years ago

Our PHP-DI container is already built before Symfony's Kernel boots. So in our AppKernel we'd like to override Kernel::getPHPDIContainer() to provide our built PHP-DI container to the SymfonyContainerBridge vs having to run through a ContainerBuilder. Any objections to this?

No BC break required.

mnapoli commented 6 years ago

Makes sense go for it!

jasonbouffard commented 6 years ago

Awesome. Thanks for the fast response. PR is up. Think we can get a 2.0.1 release quickly? Or 2.1.0?

mnapoli commented 6 years ago

Done! I think that's a record for me, thanks for the quick PR too ;)

jasonbouffard commented 6 years ago

Thank you!