PSR-11 friendly kernels

jjanvier commented 5 years ago

Hello Matthieu,

I'm not sure you'll be interested by this PR, but let's try. I was looking for something able to make me use a PSR-11 container with Symfony's kernel. And I found your bridge.

But I'd like to be able to use any kind of PSR-11 container. Hence this PR where you now have "PSR 11 compatible kernel" and specific "PHP DI compatible kernel".

If you're not interested just let me know. I'll create another bridge and refer to yours for the paternity.

What's missing:

test the catch of ContainerExceptionInterface (but I suck in PHPUnit, I'm too used to PhpSpec sadly...)
test the KernelWithPsr11Container?

mnapoli commented 5 years ago

Hi, thanks for the PR and trying to make it work with this repository!

I think those are good changes and a PSR-11 compatibility layer is great (instead of targeting PHP-DI only). But unfortunately I think this wouldn't be a good fit here:

as far as I understand there are BC breaks here (which I'd rather avoid if there is no huge gain for users)
this repository is very PHP-DI specific, so I think it would be more beneficial to have a separate (neutral) repository

So I encourage you to create a separate repository. In the future I could even refactor this one to use yours (or maybe get rid of this one if that's enough).

By the way I have a question that I will open in the diff.

jjanvier commented 5 years ago

Hello,

No problem, I totally understand your concerns :)

PHP-DI / Symfony-Bridge

PSR-11 friendly kernels #21