Zf24 - Githubissues

Rastusik commented 9 years ago

Hi Matthieu, I tried to fix the php di zf2 integration using the newest zf2 (2.4). Feel free to merge the code into the main branch, if it is good enough.

Just for the record - it might be a good idea to update the packagist configuration, since it even doesn't point to the current newest commit in the current master branch.

mnapoli commented 9 years ago

Hey thanks a lot, I am coming back from holidays so I'll have a look in the next days, but this is much welcome as I don't use ZF2 myself.

mnapoli commented 9 years ago

A question: have you been able to use it with your changes and check it works? On my end I have no way to ensure that (I don't use ZF2). Another solution would be to add a little test or demo application but I don't have much time, I don't know about you.

Rastusik commented 9 years ago

yes, I have tested it ... I will upload a demo app, maybe today, maybe during the weekend

Rastusik commented 9 years ago

so, the demo app is here: https://github.com/Rastusik/ZendSkeletonApplication/tree/php-di-integration-test

to test it, you have to clone it, and then: php composer.phar update -o cd public php -S localhost:11000

and visit http://localhost:11000/hello

Check out the GreetingController class to see the @Inject annotation working

mnapoli commented 9 years ago

OK this is awesome, thank you for doing this. Would you be interested to be the maintainer of this repository? What I think would be great would be:

I merge this pull request
I add you as maintainer
you can push the ZendSkeletonApplication into this repository in a directory (just like for the ZF1 integration there's the quickstart/ repository, see https://github.com/PHP-DI/ZF1-Bridge)
by the way you'll need to exclude the folder in .gitattributes/ to avoid that it is downloaded every time it is installed with Composer (see the same file in ZF1-Bridge: https://github.com/PHP-DI/ZF1-Bridge/blob/master/.gitattributes)
you tag a stable 1.0.0 release
then I can update PHP-DI's documentation to say that this "ZF2 - PHP-DI integration" is no longer in beta and is working fine

What do you think?

Rastusik commented 9 years ago

Well, to be honest, I could do all the things you suggested, but I'm not so sure about the maintainer position, since I cannot guarantee any spare time for the work for now. How time consuming would it be?

mnapoli commented 9 years ago

I don't think there is much to do (I've never seen a bug open here), it's basically letting you push directly into the repository if you need to fix anything or want to improve anything. No obligation to anything ;)

Rastusik commented 9 years ago

Ok, so I pushed the quickstart code into the zf24 branch, now it's your turn :) Also, if there are no obligations or anything else, I can try the maintainer role, let's see where this goes :)

mnapoli commented 9 years ago

Awesome, I've invited you for push access to this repository feel free to merge this pull request and release!

Rastusik commented 9 years ago

Cool. I have just created the 1.0.0 release. Is that all for now? Is there no other work to be done on packagist.org? I'm just asking, because I haven't done much work with packagist and with version releases yet.

mnapoli commented 9 years ago

Yep it seems all good, the version is showing up on Packagist: https://packagist.org/packages/php-di/zf2-bridge

Cool!

PHP-DI / ZF2-Bridge

Zf24 #8