search

PHP-Open-Source-Saver / jwt-auth

🔐 JSON Web Token Authentication for Laravel & Lumen
MIT License
729 stars 113 forks source link

Add PHP 8.2 `\SensitiveParameter` throughout the code base #208

Closed mfn closed 9 months ago

mfn commented 1 year ago

Summary

I just saw a PR in another project and was reminded of this, see https://www.php.net/manual/en/class.sensitiveparameter.php

This attribute is used to mark a parameter that is sensitive and should have its value redacted if present in a stack trace.

It's 8.2+ but due the being a comment, it's entirely backwards compatible.

Messhias commented 1 year ago

We can add it since it'll not make any difference for backwards versions.

mfn commented 9 months ago

Closing (my own issue), because I don't think we need an issue if someone wants to contribute this.

I've no plans doing this myself currently (it would require going through all parts and deciding if something is sensitive or not)