This PR only touches test infrastructure, no library code!
remove phpunit 9 and add support for phpunit 11
we need to keep phpunit 10.5 for the lowest PHP/Laravel combination
Note: must be minimum 10.5 otherwise it emits XML validation warnings which apparently have been fixed in later releases
remove all @test annotations and just use the test* prefix
annotations are emitting a deprecation notice in phpunit 11, getting removed in phpunit 12
I could have replaced them with annotations
but I figured it's less "typing" just using test*
removed a couple of unnecessary phpdoc (return,var,param)
github actions:
only run coverage when we actually collect
As of now, all matrix job where running coverage for no reason
use latest PHP/Laravel version when collecting coverage
removed matrix.os, was always the same value 🤷🏼
Lastly, I changed the job names from:
to
It may not look as pretty but you can finally see all the variables.
Yeah, I maybe went a bit overboard but sometimes it hard to stop :) Also: since I only touched tests and everything is "green", it's low-to-no risk.
Checklist:
[x] I've added tests for my changes or tests are not applicable
[ ] ~I've changed documentations or changes are not required~
Description
This PR only touches test infrastructure, no library code!
@test
annotations and just use thetest*
prefixtest*
matrix.os
, was always the same value 🤷🏼Lastly, I changed the job names from:
to
It may not look as pretty but you can finally see all the variables.
Yeah, I maybe went a bit overboard but sometimes it hard to stop :) Also: since I only touched tests and everything is "green", it's low-to-no risk.
Checklist:
CHANGELOG.md
~