PHPCSStandards / PHPCSExtra

A collection of code standards for use with PHP_CodeSniffer
GNU Lesser General Public License v3.0
90 stars 8 forks source link

UseStatements/KeywordSpacing: add missing "fixed" test file #303

Closed jrfnl closed 7 months ago

jrfnl commented 7 months ago

The Universal.UseStatement.KeywordSpacing sniff has a difference in behaviour between PHP < 8.0 and PHP 8.0+ due to the change in how namespaced name tokens are tokenized in PHP 8.0+.

For that reason, the KeywordSpacingUnitTest.2.inc did not have a ".fixed" file as whether or not a fix would be made depends on which PHP version the tests are being run on.

As of PHPCS 3.9.0, PHPCS will throw a PHPUnit warning for missing "fixed" files and as of PHPCS 4.0.0, this will become an error.

With that in mind, this commit adds the missing "fixed" file, but excludes that test from being run on PHP 8.0+ by overloading the getTestFiles() method and selectively removing the test case file from the list of files to test.