Tests/GetMemberPropertiesTest: sync with upstream [1] - use named items in data sets
These tests, for the most part, already had data set names in PHPCSUtils.
This commit adds the parameter name for each item in the data set, this time in an effort to make it more straight forward to update and add tests as it will be more obvious what each key in the data set signifies.
Includes updating references to individual items in data sets in the sister-test class for the Variables::getMemberProperties() method.
Includes fixing the data types in the docblocks and making them more specific, where relevant.
Tests/GetMemberPropertiesTest: sync with upstream [2] - minor docs and stability tweak
Use the more stable is_int() instead of a comparison against false for the offset calculation safeguard.
Add some guidance to the data provider docblock about the use of offsets and remove the inline trailing comma's about the same.
Sister-PR to PHPCSStandards/PHP_CodeSniffer#221
Tests/GetMemberPropertiesTest: sync with upstream [1] - use named items in data sets
These tests, for the most part, already had data set names in PHPCSUtils.
This commit adds the parameter name for each item in the data set, this time in an effort to make it more straight forward to update and add tests as it will be more obvious what each key in the data set signifies.
Includes updating references to individual items in data sets in the sister-test class for the
Variables::getMemberProperties()
method.Includes fixing the data types in the docblocks and making them more specific, where relevant.
Tests/GetMemberPropertiesTest: sync with upstream [2] - minor docs and stability tweak
is_int()
instead of a comparison againstfalse
for the offset calculation safeguard.