PHPCSStandards / PHPCSUtils

A suite of utility functions for use with PHP_CodeSniffer
https://phpcsutils.com/
GNU Lesser General Public License v3.0
53 stars 7 forks source link

Tests: rename `AssertAttributeSame` trait to `AssertPropertySame` #589

Closed jrfnl closed 4 months ago

jrfnl commented 4 months ago

The name was originally based on the name of the assertion available in PHPUnit, however, what with the introduction of the language construct named attributes in PHP 8.0, the name is now not very helpful/clear.

What this trait really does, is check the value of an object property, so let's make that more obvious in the naming.

Note: as this is an internal test-only file, this rename is not a breaking change.