Numbers::is*(): remove fault tolerance for invalid numeric literals with underscores
Numeric literals with underscores have restrictions as to where the underscores are allowed.
The Numbers class did not take this into account to have some allowance for developer error, but as a bug has now been reported for the AbstractArrayDeclarationSniff::getActualArrayKey() method, which is due to this fault tolerance, the fault tolerance will be removed and the Numbers::is*() methods will now only allow underscore separators in places where PHP allows them.
Note: There is still one restriction which is not yet handled: 1__1, i.e. two underscores next to each.
If at some point in the future a bug for this would be reported, this can be reconsidered.
Numbers::is*(): remove fault tolerance for invalid numeric literals with underscores
Numeric literals with underscores have restrictions as to where the underscores are allowed.
The
Numbersclass did not take this into account to have some allowance for developer error, but as a bug has now been reported for theAbstractArrayDeclarationSniff::getActualArrayKey()method, which is due to this fault tolerance, the fault tolerance will be removed and theNumbers::is*()methods will now only allow underscore separators in places where PHP allows them.Note: There is still one restriction which is not yet handled:
1__1, i.e. two underscores next to each. If at some point in the future a bug for this would be reported, this can be reconsidered.Includes a plenitude of additional tests.
Fixes #619
Refs:
AbstractArrayDeclarationSniff::getActualArrayKey(): add extra tests