Compatibility with PHPCS 4.0

[jrfnl]

This is just a ticket to keep track of the changes which PHPCSUtils will need to account for by the time PHPCS 4.0 comes out.

No urgency until there is sight of a release date.

As a principle, the code in PHPCSUtils should work with PHPCS 4.x. External standard shouldn't need to do anything special if they only want to support PHPCS 4.x If external standards want to continue to support PHPCS 3.x as well a PHPCS34Utils standard should be added to provide the compatibility layer, where necessary.

To do:

• [x] Work-around/account for the removal of the PHCPS native T_ARRAY_HINT and T_RETURN_TYPE tokens. https://github.com/squizlabs/PHP_CodeSniffer/commit/8cba0001d0cfdb2349b29655d42ba27f1fba315c6 Possible solution direction:

  • Add a PHPCS34Utils standard similar to the principle of PHPCS23Utils to create the BC layer.
  • Remove the tokens from the static arrays in PHPCSUtils\Tokens\Collections.
  • In a __construct() method for the PHPCS34Utils sniff, add them back to the static Collections arrays if PHPCS < 4.x is detected.
  • For all other places these are used (if any), wrap them within a defined() check.

  Other possible solution direction:

  • Have a PHPCS34Utils standard without any sniffs, but just with an <autoload> directive.
  • In a phpcs34-autoload.php file add the tokens back if they don't exist yet, but make sure that the PHP_CodeSniffer\Util\Tokens file is loaded first to prevent "constant already defined" notices. (IIRC PHPCS itself doesn't wrap PHPCS native tokens in a if (defined()).)
• [ ] Closure use tokens will be parenthesis owners in PHPCS 4.x https://github.com/squizlabs/PHP_CodeSniffer/commit/08824f327ce5e20d7528c5e838dd7fade3dcd11c This affects at least the following:
  • BCTokens::ParenthesisOpeners()
  • The BCFile::getMethodParameters()/FunctionDeclarations::getParameters() methods.
  • The BCFile::isReference()/Operators::isReference() methods.
  • UseStatements::getType()

Probably won't have any influence/impact on PHPCSUtils. Needs verification:

• [ ] Removal of the support for "old-style" (pre PHPCS 3.2.0) ignore comments. https://github.com/squizlabs/PHP_CodeSniffer/commit/86e74657e151d11de5bbb937c89fb6d7377eccf4
• [ ] Removal of the support for "old style" (pre PHPCS 3.3.0) array properties in rulesets. https://github.com/squizlabs/PHP_CodeSniffer/commit/8b5408c61671b2e64aae964a814fda891b25cc133
• [x] Verify that any JS/CSS specific code doesn't start throwing errors now the tokenizers have been removed. PHPCSUtils does not purposefully support JS/CSS anyway, but the backcompat functions and sister-functions for those in PHPCSUtils may have inherited support based on the PHPCS 2.x/3.x implementation. https://github.com/squizlabs/PHP_CodeSniffer/commit/ea52e7b48165edbcb96b10a0a5de04567e4d73f8

Other notes (no sight yet of what the impact will be, if any):

• PHPCS 4.x will drop support for PHP 5.
• PHPCS 4.x will drop support for installation via PEAR.

[jrfnl]

PRs already pulled & merged related to this issue: #109, #110, #111, #112, #137