Open jrfnl opened 10 months ago
Thank you for the initiative It sure sucks to have to redo all that as this is quite the hard cut here. Especially also for consumers or custom sniffer packages depending on the sniffer repo (as I do).
As for your new org: With this name and the hard cut already done, I wonder if this isnt also the change to do some other sure welcomed changes.
"php": ">=5.4.0"
is a bit bongers given the current PHP EOL timeline, I wonder if we couldnt just go 7.4+ from now on making also contributing easier, verifying with GA etc.People have to switch over in a new minor or possibly major anyway, so just some thoughts regarding a cleaned up release that is future proof while still maintaining a bit of BC.
Also free free to make a PR to switch out the repo on the PHP awesome list: https://github.com/php-collective/awesome-php
@dereuromark
Thank you for the initiative It sure sucks to have to redo all that as this is quite the hard cut here. Especially also for consumers or custom sniffer packages depending on the sniffer repo (as I do).
... which is exactly why I didn't think a plain abandon would be a realistic scenario. It's not as if I didn't have enough on my plate already, but this feels like one of those "too big to fail" projects, so something needed to be done. Though I very much hope people will support this move and we'll see more regular contributors to the project (instead of drive-by contributors) as it shouldn't all depend on me.
As for your new org: With this name and the hard cut already done, I wonder if this isnt also the change to do some other sure welcomed changes.
* License: Is it possible to change the license to MIT moving forward? I imagine it probably isnt
Changing the license is not really an option. It would need permission from all past contributors, so I don't think that's realistic. I also don't really think there's anything wrong with the BSD3 license.
* `"php": ">=5.4.0"` is a bit bongers given the current PHP EOL timeline, I wonder if we couldnt just go 7.4+ from now on making also contributing easier, verifying with GA etc.
Agreed. PHPCS 4.0 was already announced to have a PHP 7.2 minimum and I think I'll stick to that for the time being. Having said that, I think more regular releases will also mean more regular major releases, so (depending on time available etc) I imagine 5.0 could have an 8.0 minimum and come out in a year and half or so.
I will share posts with rough roadmap outlines and such once things quieten down a bit. First priority is getting 3.8.0 releeased.
Thank you for all the work you do, @jrfnl!
Should I copy the few open issues and PRs I had filed from the old repo, or should I hold off until you've done 3.8.0 and gotten other things more figured out?
Should I copy the few open issues and PRs I had filed from the old repo, or should I hold off until you've done 3.8.0 and gotten other things more figured out?
@anomiex Feel free to re-file your open issues/PRs in this repo. They won't go into the 3.8.0 release (only what I know is stable and ready for merge will), but I was going to ping you about them anyway ;-)
That said: I thought about making an awesome page for code sniffers and fixers alone, what do you think? Does it make sense to track all the different packages and addons, also with all those different emphasis. https://github.com/php-collective/awesome-php-sniffers Maybe we could use the current momentum to also complete this list and create awareness of this main tool.
That said: I thought about making an awesome page for code sniffers and fixers alone, what do you think? Does it make sense to track all the different packages and addons, also with all those different emphasis. https://github.com/php-collective/awesome-php-sniffers Maybe we could use the current momentum to also complete this list and create awareness of this main tool.
@dereuromark Sounds related to #7 and some other ideas I've had for a while, but never had the time to execute.
I was thinking more along the lines of a proper website for PHPCS with:
In my mind, this would be a GH Pages website on the phpcodesniffer.com domain, with things like the sniff directory automatically updated via GH actions workflows on releases of the standards which are included. Similar for the non-sniff class docs.
I already created a repo for it years ago, just never got round to filling it (though I do have some bits and pieces locally).
If you are interested in collaborating on this, I'd welcome that! Maybe we could start with opening issues about ideas for such a site in the repo ?
Not everything needs to be available from the start, we can take the time to start small and flesh the website out when time permits.
Possibly a phpDocumentor generated sub-site for the (non-sniff) classes, sort of similar to the docs which used to be generated on a release on the PEAR website.
Did you hear about: https://github.com/code-lts/doctum#readme
Hi, I don't want to start a new issue and I have just one quick question - is there some plan to split packages - one for PHPCS and one package for every standard? So one can require only standards that are needed in his stack and every standard can be upgraded independently on the whole PHPCS?
@forrest79 Not at this time. Having said that, I don't intend to accept new standards in the main repo anymore and intend to create those in separate repos which will contain a limited set of related standards.
In a way, PHPCSExtra can be seen in that light, though that was originally a way to release sniffs which use PHPCSUtils and therefore couldn't be pulled to this repo, but for the future, think a PHPCSDocs package which will contain a PSR5 and a PSR19 standards (if ever I find enough time to get it done).
OK, I understand. Thank you for a quick response,
Repost from https://github.com/squizlabs/PHP_CodeSniffer/issues/3932: