The Generic.PHP.LowerCaseType sniff needs to be updated to also handle non-lowercase types which are part of a DNF type declaration.
This commit updates the processUnionType() method to not only examine union types, but to examine all multi-token types and to do so in a slightly more performant manner and calls that method now for all multi-token type declarations.
Note: The method name now doesn't properly cover the functionality anymore, however, renaming the method would be a breaking change as the class is not final and the method not private.
Includes unit tests.
Suggested changelog entry
The Generic.PHP.LowerCaseType sniff will now enforce lowercase keyword based types for types used in PHP 8.2+ DNF types.
Description
The
Generic.PHP.LowerCaseType
sniff needs to be updated to also handle non-lowercase types which are part of a DNF type declaration.This commit updates the
processUnionType()
method to not only examine union types, but to examine all multi-token types and to do so in a slightly more performant manner and calls that method now for all multi-token type declarations.Note: The method name now doesn't properly cover the functionality anymore, however, renaming the method would be a breaking change as the class is not
final
and the method notprivate
.Includes unit tests.
Suggested changelog entry
The Generic.PHP.LowerCaseType sniff will now enforce lowercase keyword based types for types used in PHP 8.2+ DNF types.
Related issues/external references
Related #105, #387, #461, #471, #472, #473
Closes #105