Generic/ArrayIndent: improve code coverage and implement a few small improvements to the sniff code

[rodrigoprimo]

Description

This PR improves the code coverage of the Generic.Arrays.ArrayIndent sniff and also implements the following minor improvements to the sniff code:

• Use two different variables to hold the values of the expected indentation for array elements and array closing brace. Before, the same variable was being used, and its value modified, which can be confusing.
• Avoid unnecessary extra calls to ArrayIndent::processMultiLineArray() when fixing an array closing brace that is not placed on its own line.
• Remove T_COMMA from the list of tokens to ignore when looking for a token before the array opening brace. This was necessary in the past due to a bug File::findStartOfStatement() that has since been fixed.

I believe T_DOUBLE_ARROW can be removed from the list as well. With T_COMMA, I could confirm that when this token was added to the ignore list, the provided test would fail without it. The test started passing when a bug in File::findStartOfStatement() was fixed.

I was not able to do the same with T_DOUBLE_ARROW. This token was added to the list in 0425342. All the tests pass if I run PHPCS in the 0425342 revision without the T_DOUBLE_ARROW token.

Related issues/external references

Part of #146

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] This change is only breaking for integrators, not for external standards or end-users.
• [ ] Documentation improvement

PR checklist

• [x] I have checked there is no other PR open for the same change.
• [x] I have read the Contribution Guidelines.
• [x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• [x] I have added tests to cover my changes.
• [x] I have verified that the code complies with the projects coding standards.
• [ ] [Required for new sniffs] I have added XML documentation for the sniff.

[jrfnl]

Use two different variables to hold the values of the expected indentation for array elements and array closing brace. Before, the same variable was being used, and its value modified, which can be confusing.

This change confuses me more. I mean, the $expectedIndent doesn't get changed in the loop, so the $expectedCloseIndent can just be set in the original location to $startIndent or better yet, doesn't even need a separate variable and can just use $startIndent. Why make things more complex than they need to be ?

[rodrigoprimo]

Thanks for checking this PR, @jrfnl.

This change confuses me more. I mean, the $expectedIndent doesn't get changed in the loop, so the $expectedCloseIndent can just be set in the original location to $startIndent or better yet, doesn't even need a separate variable and can just use $startIndent. Why make things more complex than they need to be ?

Good point about using $startIndent directly. I failed to consider this option. I dropped the commit that added the $expectedCloseBraceIndent variable and edited the commit that fixed the extra calls to use $startIndent.

[jrfnl]

Rebased without changes. Merging once the builds passes.