search

PHPCSStandards / PHP_CodeSniffer

PHP_CodeSniffer tokenizes PHP files and detects violations of a defined set of coding standards.
BSD 3-Clause "New" or "Revised" License
805 stars 47 forks source link

Tests/Tokenizer: reorganize #492

Closed jrfnl closed 2 months ago

jrfnl commented 2 months ago

Description

Tests/Tokenizer: move tests

Move the tests directly related to the Tokenizer\PHP class into a PHP subdirectory. Move the tests directly related to the Tokenizer\Tokenizer class into a Tokenizer subdirectory.

As there are five (soon three) Tokenizer classes, having the tests for each class in their own subdirectory makes it more straight forward to see what code is covered by tests.

Tests/Tokenizer/ArrayKeywordTest: split the test class

Tests/Tokenizer/DefaultKeywordTest: split the test class

Tests/Tokenizer/DNFTypesTest: split the test class

Tests/Tokenizer/EnumCaseTest: split the test class

... into two test classes, one targetting the Tokenizer\PHP class, one targetting the Tokenizer\Tokenizer class.

While this does mean there is now some duplication between these test classes, I don't think that's problematic.

It also allows for these tests to diverge based on the specific test needs for each of the classes under test.

Suggested changelog entry

N/A