Generic/FunctionCallArgumentSpacing: improve code coverage

[rodrigoprimo]

Description

This PR improves code coverage for the Generic.Functions.FunctionCallArgumentSpacing sniff.

Related issues/external references

Part of #146

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] This change is only breaking for integrators, not for external standards or end-users.
• [ ] Documentation improvement

PR checklist

• [x] I have checked there is no other PR open for the same change.
• [x] I have read the Contribution Guidelines.
• [x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• [ ] I have added tests to cover my changes.
• [x] I have verified that the code complies with the projects coding standards.
• [ ] [Required for new sniffs] I have added XML documentation for the sniff.

[rodrigoprimo]

Thanks for the review, @jrfnl!

There are no tests with attributes, while the sniff does act on them: There are no tests with first class callable.

I added the tests that you suggested.

Regarding the attributes, I added the test you shared that triggers the sniff, and I also added another test that does not trigger the sniff to document the expected behavior. I did not add more tests as it seems to me, for the purposes of this sniff, the attributes behave just like a function call.

[jrfnl]

Regarding the attributes, I added the test you shared that triggers the sniff, and I also added another test that does not trigger the sniff to document the expected behavior.

Well, technically, both code samples trigger the sniff, but only one will trigger an error from the sniff....

[jrfnl]

FYI: I've pulled the follow up mentioned in one of my previous comments as PR #513