andypost commented 1 month ago

This is only file that needs fixes, tested using

docker run --rm -v $(pwd):/mnt -w /mnt php:8.4.0alpha2-cli-alpine find . -type f -name '*.php' -exec php -l {} \;

Description

Suggested changelog entry

Fixes #

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] This change is only breaking for integrators, not for external standards or end-users.
[ ] Documentation improvement

[x] I have checked there is no other PR open for the same change.
[x] I have read the Contribution Guidelines.
[x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
[ ] I have added tests to cover my changes.
[x] I have verified that the code complies with the projects coding standards.
[ ] [Required for new sniffs] I have added XML documentation for the sniff.

derrabus commented 1 month ago

This change is incompatible with PHP < 7.1.

jrfnl commented 1 month ago

Closing as invalid.

The PHPCS test suite was already fixed months ago in #404. This file is only used with PHP < 7.1 and PHPUnit < 7, so should NOT be changed.

andypost commented 1 month ago

Thank you, I missed that this file is not involved in never testing