Squiz/EmbeddedPhp: fix false positive when handling short open tags

[rodrigoprimo]

Description

This PR fixes a bug in Squiz.PHP.EmbeddedPhp that causes a false positive when handling short open tags and was reported in https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/588.

The content of a PHP long open tag token is <?php (note the space after the tag). The content of a PHP short open tag is <? (no space after the tag). The sniff did not account correctly for this difference when checking the expected number of spaces after a short open tag, resulting in false positives and incorrect fixes.

Suggested changelog entry

Squiz.PHP.EmbeddedPhp false positive when checking spaces after a PHP short open tag.

Related issues/external references

Fixes #588

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] This change is only breaking for integrators, not for external standards or end-users.
• [ ] Documentation improvement

PR checklist

• [x] I have checked there is no other PR open for the same change.
• [x] I have read the Contribution Guidelines.
• [x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• [x] I have added tests to cover my changes.
• [x] I have verified that the code complies with the projects coding standards.
• [ ] [Required for new sniffs] I have added XML documentation for the sniff.

[rodrigoprimo]

Thanks for reviewing this PR, @jrfnl. I applied your suggestions and it is now ready for a final check.

[jrfnl]

Closing as merged manually in 0ed5577b4e3d70ce357d19a36ab5e64587f4327c.