As it was, the plugin when used by external standards, would block them from being tested on PHP 8.
As all the dependencies in the require section allow for PHP 8, there is no reason not to allow it.
The only dependencies currently in use which do not allow for PHP 8 yet are in the require-dev section. See the below output.
This includes updating the Travis script to:
Only do a full (dev) install when not on nightly.
Ignore platform requirements on nightly as otherwise the dev requirements would still block installation.
And as PHPCompatibility is in the require-dev section, we need to require it explicitly for nightly to make sure the integration test can run.
As the Travis build on PHP nightly passes, I'm semi-confident that all should be good, though confidence will grow once we add more unit/integration tests.
Potherca
commented
4 years ago
Proposed Changes
As it was, the plugin when used by external standards, would block them from being tested on PHP 8.
As all the dependencies in the
requiresection allow for PHP 8, there is no reason not to allow it.The only dependencies currently in use which do not allow for PHP 8 yet are in the
require-devsection. See the below output.This includes updating the Travis script to:
dev) install when not onnightly.nightlyas otherwise thedevrequirements would still block installation.require-devsection, we need to require it explicitly fornightlyto make sure the integration test can run.As the Travis build on PHP
nightlypasses, I'm semi-confident that all should be good, though confidence will grow once we add more unit/integration tests.