Closed jrfnl closed 3 years ago
@Potherca Just checking: where there any changed you wanted ? Or did you assign this to me to self-merge ? (sorry, the commit process in this repo still confuses me - I'm used to never self-merge when collaborating, i.e. the (last) approver merges)
No changes needed. I just didn't feel like waiting around for Travis to complete but also didn't want to use my admin right to merge again. I assigned you in case I forgot to come back to this :joy:
Proposed Changes
While looking into the (non-)race condition described in #125, I noticed a potentially related issue.
As per the documentation of realpath():
In the rare case that
realpath()
would returnfalse
within this plugin,false
would subsequently be passed on tois_dir()
andis_readable()
which both expect a string path.This tiny change makes the condition fail earlier by checking the return value of
realpath()
.