search

PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
549 stars 36 forks source link

Add details regarding QA automation in CONTRIBUTING.md file. #133

Closed Potherca closed 2 years ago

Potherca commented 3 years ago

Fixes #123

Potherca commented 2 years ago

@jrfnl or @mjrider Does either of you have time to review my prose?

jrfnl commented 2 years ago

@Potherca Sorry that it's taken such a long time to get to this. I'd like to get this merged in before I pull the initial test setup PR.

Looking at it, it looks like some of the information is slightly out of date by now (Travis vs GH Actions and such). Have you got time to review and update it yourself ? Or would you like me to propose an update by adding a commit ?

Potherca commented 2 years ago

If you've got time, feel free to add. I'll move future branches from my fork to here so they can be more easily edited.

jrfnl commented 2 years ago

If you've got time, feel free to add. I'll move future branches from my fork to here so they can be more easily edited.

I've created the update, but looks like the checkbox to allow maintainers to edit the PR has not been checked ? A push to your fork on this PR branch is being rejected.

I'll send you a PR to update this PR 🙃

jrfnl commented 2 years ago

See: https://github.com/potherca-contrib/phpcodesniffer-composer-installer/pull/2

Potherca commented 2 years ago

@jrfnl I've merged your MR so you can merge my MR. 😬