PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
549 stars 36 forks source link

CI: various updates #140

Closed jrfnl closed 2 years ago

jrfnl commented 2 years ago

CS: minor cleanup

PHPCS 3.6.2 added a sniff for a PSR-12 rule which was previously not strictly checked: "No blank line after the opening brace of a class".

This fixes the newly flagged issues.

GH Actions: auto-cancel previous builds for same branch

Previously, in Travis, when the same branch was pushed again and the "Auto cancellation" option on the "Settings" page had been turned on (as it was for most repos), any still running builds for the same branch would be stopped in favour of starting the build for the newly pushed version of the branch.

To enable this behaviour in GH Actions, a concurrency configuration needs to be added to each workflow for which this should applied to.

More than anything, this is a way to be kind to GitHub by not wasting resources which they so kindly provide to us for free.

Refs:

GH Actions: use error_reporting=-1

... as E_ALL does not always contain all errors across PHP versions.

GH Actions: update the security checker

Ref: https://github.com/fabpot/local-php-security-checker/blob/main/CHANGELOG.md

πŸ†• GH Actions: version update for ramsey/composer-install

The action used to install Composer packages and handle the caching has released a new major (and some follow-up patch releases), which means, the action reference needs to be updated to benefit from it.

Refs:

πŸ†• GH Actions: always use --no-interaction for Composer

Adding --no-interaction to "plain" Composer commands to potentially prevent CI hanging if, for whatever reason, interaction would be needed in the future.

πŸ†• πŸ†• GH Actions: version update for actions/checkout

Ref: https://github.com/actions/checkout/releases

jrfnl commented 2 years ago

Added two extra commits for your review (and updated the PR description).

Potherca commented 2 years ago

Looks good.

jrfnl commented 2 years ago

Found yet another snippet which needed updating. Added a new commit with the additional change.

jrfnl commented 2 years ago

Anything I can do to move this PR forward ?

Potherca commented 2 years ago

I was suffering from a severe lack of time, which has now been resolved. Will look into this the coming few days :+1: