search

PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
549 stars 36 forks source link

Move repository to PHPCSStandards organisation #146

Closed Potherca closed 2 years ago

Potherca commented 2 years ago

As mentioned before in #113 it is desirable to move this project to an organization that has more contributors and higher visibility.

Currently PHPCSStandards looks like the best match.

This issue proposes to move the repository for this project from the Dealerdirect organisation to PHPCSStandards.

Opinions?

Potherca commented 2 years ago

As this motion has been seconded by both other active maintainers, lets make the move!

jrfnl commented 2 years ago

The one thing we should still discuss about this - should the package also be renamed to phpcsstandards/....

The downside of that is that 1) the stats won't be retained and 2) it will be quite a while before all users have switched over. The upside of it is that we won't be dependent on the DealerDirect organisation continuing to allow us to manage the package on Packagist.

Potherca commented 2 years ago

My current thinking is (more or less) that we should rename to phpcsstandards with release v1.0. It might be less worrisome that only the statistics for pre-1.0 will be lost that way :grin:

Regarding renaming, we might want to take it one step further and go from Dealerdirect/phpcodesniffer-composer-installer to phpcsstandards/composer-installer (as the "phpcodesniffer" part is implied in "phpcsstandards").

Potherca commented 2 years ago

Also... Do we have any reason for not pressing the "transfer" button right now?

image

jrfnl commented 2 years ago

My current thinking is (more or less) that we should rename to phpcsstandards with release v1.0. It might be less worrisome that only the statistics for pre-1.0 will be lost that way 😁

Fair enough, clean slate and all.

For the record, current stats are pretty impressive already:

image

Regarding renaming, we might want to take it one step further and go from Dealerdirect/phpcodesniffer-composer-installer to phpcsstandards/composer-installer (as the "phpcodesniffer" part is implied in "phpcsstandards").

I agree, sounds like a good plan. On that note, we can rename the repo to composer-installer as well after the move.

Also... Do we have any reason for not pressing the "transfer" button right now?

Go for it! I'll handle the accepting on the other end.

GaryJones commented 2 years ago

we can rename the repo to composer-installer as well after the move.

Does GitHub auto-redirect on a change like that?

jrfnl commented 2 years ago

@GaryJones IIRC it does.

Confirmed: https://docs.github.com/en/repositories/creating-and-managing-repositories/renaming-a-repository

Potherca commented 2 years ago

Also... Do we have any reason for not pressing the "transfer" button right now?

Go for it! I'll handle the accepting on the other end.

@jrfnl Looks like I'm not allowed:

You don’t have the permission to create public repositories on PHPCSStandards
jrfnl commented 2 years ago

Also... Do we have any reason for not pressing the "transfer" button right now?

Go for it! I'll handle the accepting on the other end.

@jrfnl Looks like I'm not allowed:

You don’t have the permission to create public repositories on PHPCSStandards

@Potherca Huh ? That sounds weird - In my view, a transfer request should be allowed to be initiated by any admin of a repo with the acceptance being the responsibility of the organisation on the other end (with a mail notifying them there is a transfer request to accept).

May be something weird on GH's end.

I'll give it a try myself. Didn't want to do that before as for "auditability/transparency" it is, of course, better if the transfer is done by multiple people showing that there is consensus about it.

As a side-note: I have already invited both you as well as @mjrider to the PHPCSStandards organisation, but looks like neither of you have accepted yet.

jrfnl commented 2 years ago

I'll give it a try myself.

Looks like that worked. Shall I rename the repo to `composer-installer straight away as well ?

Potherca commented 2 years ago

Shall I rename the repo to `composer-installer straight away as well ?

Yes please, the sooner the better IMHO.

jrfnl commented 2 years ago

Shall I rename the repo to `composer-installer straight away as well ?

Yes please, the sooner the better IMHO.

Done!

GaryJones commented 2 years ago

I had this issue open before the change was made, and I can confirm that GitHub successfully redirected me back to this issue when reloading the page. 👍🏻

Suggest: close.

jrfnl commented 2 years ago

@GaryJones Thanks for confirming. The issue will automatically be closed when #158 gets merged, which updates the references to the repo location in all relevant places in the code base.

jrfnl commented 2 years ago

@mjrider Looks like I don't get a notification mail when an invite to an organisation is accepted. Could you please leave a note here when you have ? I will then add you to the "composer plugin admins" team, which should give you admin access to the repo again.