Composer: tweak PHPCS version constraint

PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards

https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer

MIT License

549 stars 36 forks source link

Composer: tweak PHPCS version constraint #152

Closed jrfnl closed 2 years ago

jrfnl commented 2 years ago

Proposed Changes

Some of the early PHPCS 3.x versions did not support external standards correctly, so using this plugin with those would always run into trouble, so let's just make it explicit that 3.0.0 and 3.0.1 are not supported.

3.0.2 should be fine, though IIRC, even 3.1.0 contained some fixes for external standard support, so we could choose to up this to ^3.1.0 to be on the safe side.

jrfnl commented 2 years ago

Just came across issue #33 and based on the discussion in that issue, which references upstream fixes needing to be made which only got released in PHPCS 3.1.0, I do think upping the minimum for the 3.x branch to 3.1.0 seems prudent. I've updated the PR to reflect this.