PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards

https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer

MIT License

542 stars 36 forks source link

GH Actions: stop running tests against PHP 5.5/Composer 1.x on Windows (and remove work-arounds) #183

Closed jrfnl closed 2 years ago

jrfnl commented 2 years ago

Proposed Changes

GH Actions: stop running tests against PHP 5.5/Composer 1.x on Windows

As discussed in #181.

Fixes #181

Tests: remove the `TestCase::willPluginOutputShow()` helper method and all uses

This method was put in place in PR #153 (commit https://github.com/PHPCSStandards/composer-installer/commit/d4f64b822a76e1aac325f18ac160b9daac01ff49) as a work-around for the problematic PHP 5.5 / Composer v1 on Windows build.

As we won't be running the tests against that particular combination anymore, I propose we remove all these work-arounds from the test suite.

This effectively reverts the following commits (and a little more):

f0251b838a3c0461056192db13d4dab66bc7d013.
ccd127f5676213d57ba5fd29fc181b6a2c5972b0.
d4f64b822a76e1aac325f18ac160b9daac01ff49.

Related Issues

181

jrfnl commented 2 years ago

FYI: I've removed the build I'm now excluding from the "required statuses" in the branch protection rules.