PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
542 stars 36 forks source link

GH Actions: selectively use `fail-fast` with setup-php #194

Closed jrfnl closed 1 year ago

jrfnl commented 1 year ago

Proposed Changes

I've seen some recent build failures (elsewhere) due to the setup-php action running into a rate limit and not downloading the required version of Composer. In the case of this package, that would make the test runs worthless.

The setup-php action runner defaults to showing these type errors in the logs, but not stopping the workflow run.

So, specifically for those jobs where the Composer version is important, I'm adding the fail-fast option to setup-php to fail the build if the action runner ran into any errors.

Ref: https://github.com/shivammathur/setup-php#fail-fast-optional