search

PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
542 stars 36 forks source link

Replace http with https #206

Closed SplotyCode closed 9 months ago

SplotyCode commented 11 months ago

Proposed Changes

Related Issues Code scans mark it as insecure. Here it really does not matter as the side upgrades to https it is still good practise

jrfnl commented 11 months ago

@Potherca As the plugin is no longer directly associated with DealerDirect, I'm thinking we may as well remove the homepage key from the composer.json file. What do you think ?

Potherca commented 11 months ago

I'd say either point it to the repo https://github.com/PHPCSStandards/composer-installer or remove it. Either one is fine by me.

jrfnl commented 11 months ago

@Potherca As the composer.json file already contains a link to the repo in support -> source, I don't think homepage linking to the repo has any added benefit.

@SplotyCode Thanks for the PR, would you mind removing the homepage key instead ?

jrfnl commented 10 months ago

@Potherca Could you please have another look & merge if you're also okay with the changes as they are now ?