search

PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
542 stars 36 forks source link

GH Actions: fix the build #213

Closed jrfnl closed 7 months ago

jrfnl commented 7 months ago

Proposed Changes

Builds against PHP 5.4 on Windows are failing. The failure happens even before the test run at the "Composer install" step.

These failures look to be unrelated to this package, but seem to be related to PHP 5.4 trying to make an unsecured connection to Packagist and this no longer being supported. There may be ways to work around this, but I haven't been able to find one other than downloading a new certificate bundle and using that (not tested).

Considering PHP 5.4 is ancient, I'm proposing to just drop the test runs against PHP 5.4 in combination with Windows.

jrfnl commented 7 months ago

To merge this PR, the branch protection needs to be updated to remove the two PHP 5.4/Windows builds from being required.

Potherca commented 7 months ago

Is it possible to just admin-bypass the merge? That would negate the need to turn branch protection off-and on-again.

image

jrfnl commented 7 months ago

Is it possible to just admin-bypass the merge? That would negate the need to turn branch protection off-and on-again.

It is, but that would be counter-productive as we're removing those two builds, so they need to be removed from the branch protection as otherwise all future PRs will also need the admin-bypass as they are missing those two builds.