search

PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
559 stars 36 forks source link

CS: Add PHP 5.3 compatibility #39

Closed GaryJones closed 7 years ago

GaryJones commented 7 years ago

Logically follows on from #38, though isn't strictly dependent on it being merged.

The use of short syntax for arrays was the only thing stopping this package from being compatible with PHP 5.3 as well. PHP 5.3 is specified in the Travis CI config. Allowing it to be used in setups that require PHP 5.3 makes it usable for more authors (such as those in the WordPress community).

Composer also requires PHP 5.3.2 to run, so it makes sense to ensure it works with that too.

Potherca commented 7 years ago

Since this package does not use any explicit PHP 7.0 or 7.1 features, I think it would be sensible to follow the version constraint set by Composer.

GaryJones commented 7 years ago

@frenck Any feedback on this?

Here's an example of a failing Travis build which is now stopping PRs from being merged.

screen shot 2017-09-15 at 13 09 12

Potherca commented 7 years ago

Unlike the VersionEye check that failed in PR-38, this check fails because of License whitelist issues.

screenshot from 2017-09-18 09-40-37

I've added the PHP license to the whitelist. I've Triggered the check again by finding the payload in the Webhooks Settings and pressing the ↻ Redeliver button.