Closed gapple closed 6 years ago
The failing build on Travis is caused by an issue with the security-checker.
It uses code that is only PHP7.1+ compatible.
I've tagged security checker to the last release that supported PHP 5, and the Travis build is now successful.
Would it be better (and possible) to manage the version of security-checker via require-dev
in composer.json
?
I would be all for it but that is up to @frenck as I am no longer part of the organisation.
(I could ask @frenck to add me as a contributor... then I could make more contributions).
This seems to be a sane fix for the issue at hand. I will test this one asap.
@gapple About the security checker as a dependency, I'm kinda in the middle of this. IMHO, security package checking is part of a CI and not part of a development workflow (e.g., GitHub is now moving towards providing that kind of things).
So I'm fine with both solutions tbh.
This has been changed by @jrfnl in #58.
Proposed Changes
The plugin executes
phpcs
when initialized, which may cause it to include the autoloader while it's in an inconsistent state.For example, if a package that includes a static file is removed during an update (e.g. a compat library that provides global PHP functions):
This PR moves the initialization of
installedPaths
to the method which responds to thePOST_INSTALL_CMD
andPOST_UPDATES_CMD
events, so that it is only initialized just before it's actually needed.Related Issues
Fixes #49