search

PHPCSStandards / composer-installer

Composer installer for PHP_CodeSniffer coding standards
https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
MIT License
552 stars 36 forks source link

Update Travis file and fix build #86

Closed Potherca closed 4 years ago

Potherca commented 5 years ago

Proposed Changes

Currently the Travis build is breaking because the URL used by the security-checker no longer exists. This MR updates that URL to the new home in order to fix the build.

It also adds a preview for PHP 7.4 and makes minor changes to improve the build step.

Potherca commented 5 years ago

@mjrider, can you review (and optionally merge) this, if @frenck is unavailable?

Potherca commented 5 years ago

Looks like this fixes part of the issue... PHP5.4 and PHP5.5 need Trusty to build.

However, changing the matrix to this:

matrix:
  include:
    - php: 7.2
      env: SNIFF=1
    - php: 5.5
      # As the latest Debian not supporting PHP 5.5 anymore, we need to force using 'trusty'.
      dist: trusty
    - php: 5.4
      # As the latest Debian not supporting PHP 5.4 anymore, we need to force using 'trusty'.
      dist: trusty
    - php: 5.3
      # As the latest Debian not supporting PHP 5.3 anymore, we need to force using 'precise'.
      dist: precise

did not yield the expected result (i.e. Trusty being used...)

jrfnl commented 5 years ago

Oh and as you're making changes to the Travis script now anyway, why not add a build against "7.4snapshot", possibly with an allow_failures for it too ?

Potherca commented 5 years ago

@mjrider I'm all done. Can you please review/approve so these changes can be merged to master?

They are needed before I can update the other open MRs.