PHPCS 3.5.0+ contains a far more complete PSR12 ruleset.
The current code didn't fully comply with that ruleset. Some minor code tweaks fix that.
PSR12 demands constant visibility to be declared, but as this project still supports PHP 5.3 and constant visibility wasn't introduced until PHP 7.1, this is not desirable. Excluding that particular rule from within the ruleset fixes that.
@mjrider Thanks. Now we have a passing build again, I'll be sending in some more PRs to further improve the testing of the plugin. I'm sending them in staged as otherwise we'd have to fix conflicts all the time.
Proposed Changes
PHPCS 3.5.0+ contains a far more complete PSR12 ruleset.
Related Issues