search

PHPCheckstyle / phpcheckstyle

PHPCheckstyle is an open-source tool that helps PHP programmers adhere to certain coding conventions.
https://github.com/PHPCheckstyle/phpcheckstyle
GNU Lesser General Public License v3.0
164 stars 31 forks source link

Question: join forces #53

Closed keradus closed 9 years ago

keradus commented 9 years ago

Hi! Your project is similar to our - check code style. We, on the other hand, also fix it in place! What about joining forces and work together on https://github.com/FriendsOfPHP/PHP-CS-Fixer ?

jbrooksuk commented 9 years ago

Hey @keradus, we've previously looked at PHP-CS-Fixer before starting PHPCheckstyle afresh (see Hippo) but they seem to be doing different jobs.

PHPCheckstyle returns a string for each fix, explaining what you should do. Similar to Rubocop I guess. Does PHP-CS-Fixer do that? I was never able to see that.

keradus commented 9 years ago

You can see what fixers made changes via verbose option. You can also show what change need to be made by using --diff. And, if don't wan't to store it on your files - also add --dry-run.

jbrooksuk commented 9 years ago

So for example, it'll tell you that you need to use single quotes and not double?

keradus commented 9 years ago

It's a matter of fixers that the tool know. Currently there is no fixer (rule) for ' vs ". But it can be simply added. See the list of possible fixers at https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/1.5/README.rst#usage . Joining forces will allow us to build greater rules set.

For existing fixer one can only get the message that the rule is violated and where or simply fixed.

jbrooksuk commented 9 years ago

Interesting. We actually started fresh on this - which is what Hippo is, but I'd be interested in contributing to PHP-CS-Fixer for a project of mine.

keradus commented 9 years ago

So, maybe think about joining forces fron PHPCheckstyle and Hippo to work together on PHP CS Fixer. If some functionallity is missing it can be simply added. Now it is a great time for it - we are working on 2.0 version, which allows us for 2.0 version. PHP CS Fixer has quite big community so far ;)

jbrooksuk commented 9 years ago

Well PHPCheckstyle really belongs to @tchule but I'd be happy to move to PHP-CS-Fixer as a team member?

keradus commented 9 years ago

I am talking here about joining forces to stop spending time on writing two tools to do the same thing allowing to spend same time to develop one tool twice as fast, not about moving one, single contributor from one repo to another.

On PHP CS Fixer we have big community and almost 100 contributors. Tool was build originally as part of Symfony and now it is used by biggest frameworks like Symfony or ZF2. Everyone are willing to contribute.

keradus commented 9 years ago

OK, I see this repo is already dead :(

jbrooksuk commented 9 years ago

@tchule seems to have moved to SourceForge - he prefers SVN I believe.

Potherca commented 9 years ago

The sourceforge repo also looks dead...

jbrooksuk commented 9 years ago

@tchule what's going on buddy?

tchule commented 9 years ago

Hi, not a lot of time to keep up with the project. I've just moved to SourceForce because Google Code is closing soon, I wanted to keep the wiki. Not completly dead, but no activity....