search

PHPCompatibility / PHPCompatibilitySymfony

PHPCompatibility rulesets which can be included in projects using the Symfony polyfill libraries
GNU Lesser General Public License v3.0
6 stars 4 forks source link

Update version of Composer PHPCS plugin + fix Travis build #21

Closed jrfnl closed 4 years ago

jrfnl commented 4 years ago

Update version of Composer PHPCS plugin

The DealerDirect Composer plugin has released version 0.7.0 a few months ago, which is compatible with Composer 2.x. As Composer 2.0 has just been released, we should make sure not to recommend installing an older version of the plugin than 0.7.0.

We also need to make sure we use the right version of the plugin ourselves in the require-dev.

As Composer treats minors < 1.0 as majors, updating to this version requires an update to the composer.json requirements.

For pre-1.0 versions it also acts with safety in mind and treats ^0.3 as >=0.3.0 <0.4.0.

Refs:

Travis: fix the build

  1. The polyfill master branches have been renamed to main.
  2. There's been a snafu in the Polyfill meta-repo. They've updated the minimum PHP version to PHP 7.1 and intended to make the polyfills for PHP < 7.2 stand-alone, but they actually rolled the minimum change out to the packages and tagged a release, which makes any version of the polyfills for PHP < 7.2 useless as they can no longer be installed. sigh Left a comment in the PR upstream. Hopefully they'll fix this in one way or another, but in the mean time, 1.19 is the last installable version of these polyfills.

I've fixed this for now by moving the install instructions to the jobs matrix and letting each build have its own variation to allow the packages to install.