search

PHPCompatibility / PHPCompatibilitySymfony

PHPCompatibility rulesets which can be included in projects using the Symfony polyfill libraries
GNU Lesser General Public License v3.0
6 stars 4 forks source link

Request to Add polyfill-php81 #34

Open enkhtulga-gantsagaan opened 2 years ago

enkhtulga-gantsagaan commented 2 years ago

I'd like to request to add polyfill-php81.

jrfnl commented 2 years ago

@enkhtulga-gantsagaan Ready in draft, but as there is no release of PHPCompatibility yet which includes the PHP 8.1 notices (sorry, they are in develop), PHPCompatibilty won't throw any errors/warnings for PHP 8.1 issues yet. Adding the ruleset here doesn't make sense yet until PHPCompatiblity 10.0.0 is being released.

fredericgboutin-yapla commented 2 months ago

You could update the master branch (or observe that develop branch git-flow scheme they do) so at least we can move forward

See, https://github.com/PHPCompatibility/PHPCompatibility/issues/1312#issuecomment-2302446408

fredericgboutin-yapla commented 2 months ago

I've created a fork here, https://github.com/Yapla-Labs/PHPCompatibilitySymfony

So at least I can install this package using the 10.x-dev branch. I can also add the missing polyfill exclusions as we are using them.

In the composer.json add,

  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/Yapla-Labs/PHPCompatibilitySymfony.git"
    }
  ]

And then composer require --dev -W phpcompatibility/phpcompatibility-symfony:dev-master

I realize now that I should have probably checkout a 10.x-dev branch but oh well.