search

PHPFusion / PHPFusion

PHPFusion Official Development Repository
https://phpfusion.com
GNU Affero General Public License v3.0
112 stars 118 forks source link

makepagenav function #2419

Closed MathiasHun closed 1 year ago

MathiasHun commented 1 year ago

core_functions_include.php

makepagenav function

"First" and "Last" buttons do not work properly. It's not pointing to the right place.

PHPFusion version: v9.10.30

FrederickChan commented 1 year ago

Any URL to test on? like news, forum url, etc. I suspect integration is wrong.

karrak1 commented 1 year ago

the goal is to test the fix. https://github.com/PHPFusion/PHPFusion/blob/3970d7b9df6f4fc2c849e2402cc399b721699000/includes/core_functions_include.php#L1746 and https://github.com/PHPFusion/PHPFusion/blob/3970d7b9df6f4fc2c849e2402cc399b721699000/includes/core_functions_include.php#L1781

MathiasHun commented 1 year ago

It works well with this.

FrederickChan commented 1 year ago

I have a working template version running on twig. Truth to be told here is that I'm worried twig direct integration now will push the package larger in size. Because my work now is A LOT bigger than the repository. I think it is best for us to slim down. This includes removing bootstrap altogether in the next release into a new plugin container. This way we can develop separate packages for users. Like if you want bootstrap 3 , enable bs3 plugin. We do an extra admin page to control these in system settings folder.

Give me some time to sort this out. I'll revise and come out with the new db and modules.

So for now let's just accept this patch in.

FrederickChan commented 1 year ago

When we did bs3 direct integration it was due to