search

PHPGangsta / GoogleAuthenticator

PHP class to generate and verify Google Authenticator 2-factor authentication
http://phpgangsta.de/4376
BSD 2-Clause "Simplified" License
2.26k stars 698 forks source link

Introducing namespace #47

Open chaos0815 opened 7 years ago

chaos0815 commented 7 years ago

As the title says the code is now using a namepsace. I've adjusted the test accordingly. please excuse the format changes. Bad habit of mine.

chaos0815 commented 7 years ago

Sorry for the erratic commits. but I'm not used to working with travis.

chaos0815 commented 6 years ago

Well, is there something opposing a merge? Asking for a friend.

Dennis1993 commented 6 years ago

Why a space between the dots? That makes it very confusing

chaos0815 commented 6 years ago

@Dennis1993 whitespace between operands confuses you?

Ryan6578 commented 6 years ago

@chaos0815 I think this project is abandoned.

chaos0815 commented 6 years ago

@PHPGangsta Michael, some feedback would be appreciated on why you would not accept this pull request. I believe introducing namespaces is the right way to go and I don't see any reasons not to.

Ryan6578 commented 6 years ago

@chaos0815 Once again, I'm pretty sure the project is abandoned. He's not going to get back to you because he is no longer interested in maintaining the project.

chaos0815 commented 6 years ago

@Ryan6578 and you would know because?

Ryan6578 commented 6 years ago

@chaos0815 Look at the repository. The owner's last commit was nearly 2 years ago, the last time he merged a PR was nearly 2 years ago. There's been no activity from him on this repository since then. That's how I know.

MarkMaldaba commented 3 years ago

Also, one of the nice things about this implementation, as opposed to some of the alternative libraries that are out there, is that it works on pretty much all PHP versions, including older PHP 5. Therefore, I don't think it's a great idea to introduce this kind of change, which removes that support for no actual benefit.